refactor: share primitive length, LE-segment and chunked-combine helpers - #448
Merged
Merged
Conversation
- Six writer encoders each switched over ptype just to read a carrier array's length; they now call java.lang.reflect.Array.getLength. - Zstd and Primitive both hand-rolled per-element loops copying a heap carrier into a little-endian segment; PrimitiveArrays.toSegment does it with one bulk MemorySegment.copy, aligned to the element width. Primitive still wraps byte[] in place. - ChunkedEncodingDecoder duplicated ChunkedArrayCombiner's primitive switch; it now calls ChunkedArrayCombiner.combinePrimitive. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
array's length; they now call java.lang.reflect.Array.getLength.
carrier into a little-endian segment; PrimitiveArrays.toSegment does
it with one bulk MemorySegment.copy, aligned to the element width.
Primitive still wraps byte[] in place.
switch; it now calls ChunkedArrayCombiner.combinePrimitive.
Verified with
./mvnw verify(unit + integration).🤖 Generated with Claude Code