feat(writer): global-dict Binary columns like Rust's dict layout - #443
Merged
Merged
Conversation
Rust's dict layout admits Primitive | Utf8 | Binary (dict_layout_supported); the Java writer left Binary out. Binary values are keyed by a ByteBuffer view so equal bytes in distinct byte[] instances dedup by content. Adds DictAllTypesInteropIntegrationTest: vortex-jni writes a low-cardinality column of every Arrow type, Java rebuilds every value, and the test pins which types Rust dict-encodes. Rust never dicts uuid/date/FSL/bool/decimal, so compatibility.md downgrades that dict-layout row from a gap to unreachable. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
dfa1
force-pushed
the
feat/global-dict-binary
branch
from
October 3, 2026 12:45
1ff6553 to
9283dae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rust's dict layout admits
Primitive | Utf8 | Binary(dict_layout_supported); the Java writer's global dict leftBinaryout. This brings it to parity.DictColumnState/VortexWriter: Utf8 global-dict path generalized to VarBin (Utf8 + Binary); Binary keyed byByteBuffer.wrapfor content equality.DictAllTypesInteropIntegrationTest: vortex-jni writes a low-card column of 23 Arrow types; Java rebuilds every value; asserts which types Rust dict-encodes (only primitives/strings).JavaWritesRustReadsIntegrationTest#javaWriter_rustReader_globalDict_nullableBinary: dict layout present, vortex-jni reads full + filtered (verified red without the fix).docs/compatibility.md: dict layout over uuid/FSL/date pools is unreachable from Rust- or Java-written files (🤖 Generated with Claude Code