Repository navigation
Fix: loader di caricamento delle tabelle - #1926
Open
Andrea-Bruno wants to merge 1 commit into
Open
Andrea-Bruno wants to merge 1 commit into
Andrea-Bruno wants to merge 1 commit into
Conversation
The tables showed a separate loader pinned to the bottom-right corner while results were loading. The DataTables library already provides a processing slot that is shown and hidden on its own, so the corner loader and its manual show/hide handlers are dropped in favour of that slot, filled with a FontAwesome spinner.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ciao e grazie per il progetto.
Ho letto la issue #1608 e ho preparato una correzione.
Il problema era questo: mentre una tabella caricava i risultati compariva una piccola animazione in basso a destra, separata dalla tabella stessa. Questa animazione era gestita a mano dal nostro codice, che la mostrava e la nascondeva a comando.
La libreria che usa le tabelle, pero', mette gia' a disposizione un suo spazio dedicato all'avviso di caricamento, e lo fa comparire e sparire da sola nei momenti giusti. Non serviva quindi un secondo loader esterno.
La correzione che ho fatto toglie il loader in basso a destra e i comandi manuali che lo mostravano, e usa invece lo spazio nativo della libreria, riempito con un'icona che gira presa da FontAwesome, che il progetto usa gia' altrove. Cosi' l'avviso di caricamento appare sopra la tabella che sta lavorando, dove l'occhio lo cerca, invece che in un angolo della schermata.