Repository navigation
fix: keep a pending follow button from flipping to Unfollow under the pointer - #822
Open
sulimanbenhalim wants to merge 1 commit into
Open
sulimanbenhalim wants to merge 1 commit into
sulimanbenhalim wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
right after following someone the button flips to a red Unfollow under the pointer even though
useFollowHoveris there to keep it on Following until the pointer leavessince #573 a pending follow renders the button
disabledand the baseButtonhasdisabled:pointer-events-noneso the browser fires amouseleaveas soon as the request starts and that resets the guardkeeping pointer events on the pending follow button fixes it
it's still disabled so clicks during the request do nothing and a double click still sends a single follow
moving away and back still shows Unfollow like before
added a test in
FollowState.test.tsxthat fails without the change