Repository navigation
fix: show a commit as checked only while an AI check is queued - #516
Open
SanderMuller wants to merge 1 commit into
Open
SanderMuller wants to merge 1 commit into
SanderMuller wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A pending commit counted as "being checked" whenever it had no AI decision yet and was less than 15 minutes old. Nothing checked that a check was actually queued. A reputable author with a recent report gets a pending commit, but
CreateCommitskipsModerateCommitfor reputable authors. So for 15 minutes the author saw "checking", and the client kept pollingcommits/{commit}/status, for a check that never runs. The job's early returns left the same state behind.Now the check leaves a marker:
CreateCommitwritesai_decision = pendingexactly when it dispatchesModerateCommit.isBeingChecked()looks for that marker. The 15-minute limit stays, for a job that is lost.ModerateCommitclears the marker on both early returns and in a newfailed(). It clears it only while it is stillpending, so a verdict written in the meantime stays.ai_decisionstays hidden outside moderation. The moderation page still shows "No AI decision yet" for a queued commit, and its TS type now allowspending. No migration: the column is a string cast toCommitStatus, which already haspending. A commit that was queued before the deploy has no marker, so it stops showing "checking" early.Several of the changed cases in
CreateCommitTest,ModerateCommitTestandCommitStatusControllerTestfail onproduction. That includes the reputable author with a report, who gotisBeingChecked() === true.#104 also changes
CreateCommit.php,Commit.phpandtypes/commit.ts, in other lines, so one of the two may need a small rebase.🤖 Generated with Claude Code