Skip to content

feat: suggest developers from profile and discussion context - #1021

Merged
xHeaven merged 1 commit into
dev-null-sh:productionfrom
MrPunyapal:feat/contextual-developer-suggestions
Oct 23, 2026
Merged

xHeaven merged 1 commit into
dev-null-sh:productionfrom
MrPunyapal:feat/contextual-developer-suggestions

Conversation

@MrPunyapal

@MrPunyapal MrPunyapal commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Make Who to Follow suggestions more relevant to the page you’re viewing.

On a profile, suggest developers that person follows. On a commit page, suggest developers who took part in the visible thread. If there aren’t enough contextual suggestions, fill the remaining spots with the existing suggestions.

Muted, blocked, dismissed, and otherwise ineligible users stay excluded. Suggestions still include only developers with a visible top-level commit. Daily ordering, refresh rounds, and spare suggestions continue to work as before.

Contextual suggestions load separately for each page, so visiting another profile or thread won’t reuse results from the previous one.

@xHeaven

xHeaven commented Oct 23, 2026

Copy link
Copy Markdown
Member

Let me know when this is ready for review :)

@MrPunyapal
MrPunyapal force-pushed the feat/contextual-developer-suggestions branch from 7844e69 to 333524e Compare October 23, 2026 11:51
@MrPunyapal
MrPunyapal marked this pull request as ready for review October 23, 2026 11:56
@MrPunyapal

Copy link
Copy Markdown
Contributor Author

@xHeaven done (I hope so I (my agent) had to do some struggle to run tests locally)

@xHeaven

xHeaven commented Oct 23, 2026

Copy link
Copy Markdown
Member

Note

This message is generated by an AI agent on behalf of @xHeaven. It may contain errors—verify important details.

The assertion error is fixed, and all 32 focused tests now pass. There are still three issues on 333524e2:

  1. Dismissing a suggestion reshuffles the other visible rows. HandleInertiaRequests.php:118 still drops merge metadata for contextual pages. Dismissing one person fills their slot from the spares, then the background top-up replaces and reorders the remaining suggestions. Please preserve merge-by-id behavior for top-ups while keeping different page contexts separate.

  2. Quote authors are missing from contextual thread suggestions. SuggestedUsersQuery.php:125–127 only selects the root and commits sharing its root_id. Quotes appear under the commit through quoted_commit_id, so their authors are skipped. I reproduced this again with an eligible quote author outside the general suggestion pool: their quote appears in the discussion, but they never become a contextual candidate. Please include visible quote participants.

  3. Hidden branches still supply contextual participants. SuggestedUsersQuery.php:124 checks each commit's visibility without checking whether its branch is visible. I reproduced this again with someone whose only reply is beneath a muted reply: the branch is hidden from the discussion, but its author becomes a contextual candidate. Please match the participant selection to the thread's visibility rules.

Please add regression coverage for contextual dismissal top-ups, quote participants, and participants under hidden branches.

@MrPunyapal
MrPunyapal force-pushed the feat/contextual-developer-suggestions branch from 333524e to 6876278 Compare October 23, 2026 19:44
@MrPunyapal

Copy link
Copy Markdown
Contributor Author

@xHeaven

@xHeaven

xHeaven commented Oct 23, 2026

Copy link
Copy Markdown
Member

@xHeaven

Thank you! Will merge once CI is green.

@xHeaven
xHeaven merged commit f50862c into dev-null-sh:production Oct 23, 2026
5 checks passed
Taldres added a commit to Taldres/dev-null.sh that referenced this pull request Oct 24, 2026
Takes the context the web passes since dev-null-sh#1021: `username` for a profile, `commit_id` for a commit the user can see, as its page requires. Without either, the suggestions stay as they were.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants