Repository navigation
A fixed duration is its atom's time; integrated costs compared to rounding - #359
Merged
Merged
Conversation
…nding With the fixed-duration tolerance rounding cannot cross (#358), a time known exactly is told fixed on every numpy, but was given its mean, which numpy 2.0 sums to 1.9999999999999996 for 2: it is now the time of its one atom. The planned-outage test that compares a run's costs, the exact means integrated by quadrature, with whole numbers compares them to rounding: at the floors the integrals come out at 19.999999999999996 and 20.000000000000057 for 20. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016Ng6hwUY8zznhm1jRfZJqZ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The last failure of
test (minimum dependencies)on the release pull request (#353), after #358:test_maintenance_that_takes_time_is_a_planned_outagecompared a run's costs, which are the exact means integrated by quadrature, with whole numbers exactly; at the floors (numpy 2.0.0) the integrals come out at 19.999999999999996 and 20.000000000000057 for 20, where newer numpy sums them exactly. The comparison is to rounding (pytest.approx).Also, with the tolerance #358 set, a time known exactly is told fixed on every numpy but was given its mean, which numpy 2.0 sums to 1.9999999999999996 for a duration of 2: it is now the time of its one atom (
_atoms), exact.At the floors:
test_preventive_maintenance.py,test_expected_window.py,test_start_from_state.py,test_point_availability.py,test_hidden_failures_timed.pyandtest_total_cost.pypass (249 passed), and the full suite at the floors is being run locally before this merges. Currently the same files pass; black, flake8 and mypy clean.Generated by Claude Code