Repository navigation
The crews' system has the jump_times hook; two tests follow dev's changes - #356
Merged
Merged
Conversation
…nges The window counts ask whatever chain they are given (_atom_groups, _before_period_end) for the times its states jump down, a common-cause group's members' tests that take time (#220): the groups' system has them, and the repair crews' (CrewSystem) did not, so every count over a window with limited crews around a nested RBD failed on the release pull request (#353). Its chain jumps nowhere at exact times: none. Two tests follow what dev changed. The cost analyses refuse a diagram with nothing priced (#351), so the condition test that compares a threshold no age reaches with running to failure prices the repairs. And the ample-crews test compared the chain's counts with the independent nodes' to 1e-6, where each path's quadrature is within about 2e-6 of the closed form over the shortest window (the chain's now the closer, since the chains' bends are the integrals' pieces): 5e-6. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016Ng6hwUY8zznhm1jRfZJqZ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The full suite on the release pull request (#353) failed four tests that
dev's late merges left behind (nothing ran them: the suite runs only on the pull request intomaster).CrewSystem.jump_times. The window counts ask whatever chain they are given (_atom_groups,_before_period_end) for the times its states jump down, a common-cause group's members' tests that take time (Common-cause group whose members take time to repair or test is refused by every exact method, with no way forward #220, the review-b merge). The groups' system has the hook; the repair crews' system did not, so every count over a window with limited crews around a nested RBD raisedAttributeError(three tests intest_chains_over_time.py). The crews' chain jumps nowhere at exact times: it returns none.test_condition_long_run: the cost analyses now refuse a diagram with nothing priced (The small and medium issues, and the 0.14 persona review's fixes #351), so the test comparing a threshold no age reaches with running to failure prices the repairs on both diagrams.test_ample_crews_through_the_chain_are_the_independent_values: compared the chain's counts with the independent nodes' to 1e-6, where each path's quadrature is within about 2e-6 of the closed form over the shortest window (0.0506301 exactly; the chain's 0.05063005, the independent 0.05062999). The review-b merge, making the chains' bends the integrals' pieces, moved the chain's value closer to the exact one and the two paths 1.14e-6 apart. The tolerance is 5e-6, with the reason noted.black, flake8 and mypy (2.3.0) clean;
test_chains_over_time.py,test_condition_long_run.py,test_expected_window.py,test_ccf_timed.pyandtest_crew_chain.pypass.Generated by Claude Code