Repository navigation
Narrow a minimal-repair curve's grid values for mypy 2.3.0 - #355
Merged
Merged
Conversation
MinimalRepairCurve keeps its grid's values (up, failures) as optional beside its times, set together. mypy 2.3.0, which CI pins, does not narrow them with the times at np.interp, and failed the release pull request (#353); mypy 2.3.1 does. Each read asserts the invariant. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016Ng6hwUY8zznhm1jRfZJqZ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI's lint job failed on the release pull request (#353): mypy 2.3.0, which
pyproject.tomlpins, reportsMinimalRepairCurve.atandeventspassing anOptionalarray (up,failures) tonp.interp. The arrays are set together withtimes, which the methods already check; mypy 2.3.0 does not carry that narrowing to them (2.3.1 does, which is whyscripts/check.shpassed locally with a newer mypy on the path). Each read now asserts the invariant. No behaviour change.Reproduced with
python -m mypy --python-version 3.11 repyabilityon mypy 2.3.0 (2 errors), clean after the change; black and flake8 clean;test_minimal_repair_timed.pypasses.Generated by Claude Code