Repository navigation
Conversation
Same-repo PR branches fired every workflow twice per commit (push + pull_request), ~73 jobs against the 20-job concurrency limit. Limit push to master (plus tags for build_wheels, whose Release job needs tag refs). PRs run the same jobs via pull_request; workflow_dispatch is unchanged for testing a branch without a PR. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Rt4UYn6zqR9uS7DWNGEBYx
Member
|
Thanks for the effort. I'm not really bothered by wait times atm, and actually find the run/commit quite handy in my development workflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Welcome to deepTools GitHub repository! Please check the following regarding
your pull request :
ci:)CI-only change (6 workflow trigger blocks); no code, docs or wrapper changes.
Why
Every commit to an in-repo PR branch currently runs each CI workflow twice, once for
pushand once forpull_request: about 73 jobs (~430 job-min) per commit. The 20-concurrent-job limit (5 for macOS) is saturated on every commit we sampled, so jobs wait a median of ~14 min for a runner.tests_planemojobs take ~8 min, but the workflow's median wall is ~26 min (last 30 days, n=35). PRs from forks, which only firepull_request, finish the same workflow in a median 16 min.What
Adds
branches: [master]to thepushtrigger of tests_planemo, tests_pytest, tests_ruff, tests_docs, tests_rust and build_wheels, plustags: ["*"]for build_wheels so its tag-gated Release job still publishes. This matches what #1463 did for build_wheels_preview.pull_request.masterstill gets push CI after merge; the tests_rust weekly schedule is unchanged.workflow_dispatchstays on all six workflows.One behaviour change: a branch pushed without a PR no longer runs CI automatically. Use "Run workflow" (
workflow_dispatch) or open a draft PR. To revert, restore theon:lines.Measured
Measured in a fork (agarg21/deepTools), 3 commits per arm, interleaved, same workflows, fork-internal PRs so both
pushandpull_requestfire as they do here:Counted runs (all green): before 39192578097, 39198301119, 39203849377 (27.3 / 25.5 / 26.6 min); after 39196991421, 39202031910, 39207138393 (15.4 / 16.3 / 15.9 min). Caveat: if the org has more than 20 concurrent job slots, the wall gain is smaller, but the job-minute saving holds.
AI assistance: prepared with Claude Code (Anthropic); reviewed and submitted by Apoorva.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Rt4UYn6zqR9uS7DWNGEBYx