Repository navigation
Conversation
- crate-type rlib + cdylib; new 'python' feature (default on) gates pyo3 and the five command modules (bamcoverage, bamcompare, computematrix, alignmentsieve, multibamsummary). calc, covcalc, filehandler, filtering and normalization are pure Rust and build without python. - Verified: cargo build with and without the feature; cargo test (51 pass)
WardDeb
reviewed
Oct 19, 2026
WardDeb
left a comment
WardDeb
left a comment
Member
There was a problem hiding this comment.
Looks ok to me. Two things need fixing:
In case you want to have a separate crate, the version in cargo would need to be put under release-please control (right now just a 0.1.0 placeholder AFAIK), as I think it'd make sense to have these in sync.
'hp' was ok given that we don't have it as a separate crate, deeptools-core or something among those lines would be more appropriate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This would enable to vendor-in deeptools core into other packages/ extensions (outlook: single-cell deeptools.)