Repository navigation
Conversation
Collaborator
|
@ABACUS-PR-BOT please review this PR |
mohanchen
reviewed
Oct 15, 2026
mohanchen
added
Refactor
ABACUS-PR-BOT
left a comment
ABACUS-PR-BOT
left a comment
Collaborator
There was a problem hiding this comment.
Static review at 0b686d8838fc, independently reviewed by two agents. Two P2 findings are detailed inline. The pinned governance and whitespace checks returned no errors; builds and runtime tests were not run, and CI diagnostics were unavailable.
Non-blocking: please add the exact validation commands and outcomes (including checks not run) to the PR description, plus a short description or authoritative link for the new reader-v1 SOC spin_symmetry tail, or a concrete no-docs-needed rationale.
AroundPeking
force-pushed
the
abacus-librpa-module-layout-oct15
branch
from
October 16, 2026 10:20
627e641 to
01bb5eb
Compare
mohanchen
approved these changes
Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After the reader-v1 producer exports were merged in #8053, the LibRPA producer implementation still lived under module_ri. This mixed RPA-owned export and symmetry code with the RI implementation and obscured the dependency direction.
Change
Move the LibRPA producer sources and unit tests into module_rpa. Add focused module_librpa_io helpers for Brillouin-zone sampling, structure symmetry, and unit conversion, and add SOC-symmetry producer coverage. Keep RI as a lower-level dependency used by RPA, without adding RPA dependencies to module_ri.