Repository navigation
fix(csi): take the sidecar verbosity from the module logLevel - #225
Merged
Merged
Conversation
The CSI sidecars (provisioner, attacher, resizer, snapshotter and node-driver-registrar) ran with a fixed --v=5 whatever the module was configured with. At that level node-driver-registrar alone writes seven lines per health check and the controller sidecars log every lease renewal, so an idle module fills the logs with noise and logLevel in ModuleConfig changes nothing. helm_lib_module_klog_verbosity maps the module logLevel to a klog level: ERROR 0, WARN 1, INFO 2, DEBUG 4, TRACE 5. A module without logLevel gets INFO, so the sidecars now run at --v=2, the upstream production default, and TRACE keeps the old --v=5 for debugging. Bump chart version to 1.72.29. Signed-off-by: v.oleynikov <vasily.oleynikov@flant.com>
krpsh123
approved these changes
Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The CSI sidecars rendered by
helm_lib_csi_controller_manifests(provisioner, attacher, resizer, snapshotter) andhelm_lib_csi_node_manifests(node-driver-registrar) no longer run with a fixed--v=5. Their klog verbosity now comes from the modulelogLevel, through the newhelm_lib_module_klog_verbosityhelper:--vlogLevel)Chart version 1.72.29.
Every module that renders these defines changes its sidecars from
--v=5to--v=2by default, including modules without alogLevelsetting.--v=5is still available withlogLevel: TRACE.Why do we need it, and what problem does it solve?
At
--v=5, an idle module writes a lot of log lines that carry no information. On a 17-node cluster, csi-nfs wrote 135,000 lines in two hours with no volume operations. node-driver-registrar alone writes seven lines per health check every 10 s, and the controller sidecars log every lease renewal and every failed lease acquisition on the standby replica. SettinglogLevelin the ModuleConfig did not change any of that, because the sidecars ignored it.--v=2is the upstream default for production.What is the expected result?
logLevel, or withlogLevel: INFO, the sidecar containers ofcsi-controllerandcsi-nodeget--v=2.logLevel: DEBUGthey get--v=4; withTRACEthey get--v=5.kubectl logs ds/csi-node -c node-driver-registrarstops printing the health-check lines at the default level.Checklist