Repository navigation
[deckhouse-cli] Update the logic for creating the cluster-configuration secret - #514
Merged
Merged
Conversation
Signed-off-by: Losev Valery <valery.losev@flant.com>
VaLosev
force-pushed
the
fix/edit-static-cluster-configuration
branch
from
October 18, 2026 07:36
3e907c5 to
7c20d46
Compare
VaLosev
marked this pull request as ready for review
October 20, 2026 09:39
ldmonster
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the
deckhouse-controller edit static-cluster-configurationcommand allows for the creation of a secret if it does not already exist.However, the
d8-clitool only supports editing an existing secret; if the secret is missing, the command returns an error:This PR adds logic to create the secret if it is absent from the cluster when the
d8 p edit static-cluster-configurationcommand is executed.P.S. A check is included to ensure that the user has actually made changes.
P.P.S. Explicit argument passing has been added to
provider-cluster-configuration.goandcluster-configuration.gobecause a new parameter, "createOpts *CreateOptions", has been introduced inBaseEditConfigCMD.The current logic for creating the secret is as follows:
d8(current)d8-static-cluster-configurationNotFoundNotFoundd8-cluster-configurationNotFound(OnAbsentFor → nil)d8-provider-cluster-configurationcloud-provider-<name>ModuleConfigis not enabled (RejectLegacyProviderEditOnMcFlow)