Repository navigation
Require matching types when validating Literal values - #39
Merged
Merged
Conversation
Owner
|
Changes look good, @bensynapse ! Thank you for your contribution. Now I have a reason to work toward another trycast release... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I run Live Tennis API.
trycast(Literal[1], True)currently returnsTrue, andLiteral[1]also accepts1.0or an equalIntEnummember.Literal matching now checks the runtime type before comparing values, following the typing specification.
The regressions cover these collisions across
trycast,checkcastandisassignable, including mixed Literals and a TypedDict field.Ordinary numeric annotations keep their existing coercion rules.
Checked with
poetry run make test,poetry run make lint,poetry buildand the project tox environments on CPython 3.10 to 3.14.The new tests produce 15 failing assertions against the original validator.