fix: allow oauthlib 4.x - #966
Open
hannonpi1228 wants to merge 2 commits into
Open
hannonpi1228 wants to merge 2 commits into
hannonpi1228 wants to merge 2 commits into
Conversation
Signed-off-by: Paddy Hannon <pih@ehukai.com> AOS-Session: 01a0f91e-4c76-7691-9cc7-acaa414b4a20 AOS-Session: pi-1790885871-80347-0ea3f429 AOS-Commit-Time: 2026-10-01T20:25:07Z
Signed-off-by: Paddy Hannon <pih@ehukai.com> AOS-Session: pi-1790885871-80347-0ea3f429 AOS-Commit-Time: 2026-10-01T20:33:15Z
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #964
Summary
oauthlibconstraint from^3.1.0to>=3.1.0,<5.0.0so the 4.x line can be resolved.oauthlibto4.0.0, so this project no longer resolves a version flagged by CVE-2026-49264 / CVE-2026-49265.Why widen rather than require
>=4.0.0?Both advisories are provider-side (
RevocationEndpointJSONP injection, and the PKCE code-verifier comparison in server-side token handling). This connector is a pure OAuth client:src/databricks/sql/auth/oauth.pyonly usesWebApplicationClient(prepare_authorization_request,parse_request_uri_response,prepare_request_body,prepare_refresh_body) plusOAuth2Error, none of which are affected.So a hard
>=4.0.0floor would force-upgrade consumers and risk resolver conflicts for anyone whose other dependencies still capoauthlib <4, with no security benefit. Keeping the3.1.0floor preserves compatibility, while the lock bump means the connector itself ships on the patched release and stops showing up inpip-auditoutput.Validation
poetry run python -m pytest tests/unitwithoauthlib 4.0.0actually installed: 583 passed, 237 skipped.test_auth.py,test_oauth_persistence.py,test_token_federation.py) pass against 4.0.0, confirming the client-side API surface is unchanged.Signed-off-by: Paddy Hannon pih@ehukai.com