Repository navigation
fix: ignore non-apiKey security schemes in operation form - #61
Merged
Merged
Conversation
Operations declaring an oauth2 (or http / openIdConnect) security scheme crashed the operation page: the form builder indexed schema.properties by the scheme's `in`, which only apiKey schemes have. Only apiKey schemes in header/query now produce a field, parameters with an unknown location are skipped, and every scheme of a combined security requirement is resolved. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Operations declaring an
oauth2,httporopenIdConnectsecurity scheme crashed the operation page (Cannot read properties of undefined (reading 'properties')): the form builder indexed the form sections by the scheme'sin, which onlyapiKeyschemes have.apiKeyschemes located inheaderorquerynow produce a form field; other scheme types are skipped.cookieandbodywere).{ a: [], b: [] }) is resolved, not only the first one.getVJSFSchemafor these cases.Why: data-fair now declares an
oauth2scheme (NHI scopes) on its dataset operations, so opening any operation in the dataset API doc fails.