Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[x] Wrote test for feature
[ ] Added changes to CHANGELOG.md
Changes proposed:
Adds
test_join_no_matching_valuestotests/test_tables.py. It covers the case whereTable.joinreturnsNonebecause no join values match, even though both tables have rows.The existing tests that check for
None(test_join_no_rows,test_join_with_empty_selfandtest_join_with_empty_other) all use an empty table. Those return early from thenum_rows == 0check injoin, before_join_helperruns, so theif not joined_rows: return Nonebranch in_join_helperhad no test. The new test reaches that branch for both a single-column join and a multi-column join.Addresses Issue #476