Skip to content

fix(dash-spv): verify filter batches against the full script set before commit - #958

Closed
PastaPastaPasta wants to merge 2 commits into
devfrom
fix/filter-rescan-full-set-commit
Closed

PastaPastaPasta wants to merge 2 commits into
devfrom
fix/filter-rescan-full-set-commit

fix(dash-spv): hold batch commits while any active batch has blocks i…

7b4d22e
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 13, 2026 in 1s

76.52% (+0.04%) compared to 173ffac

View this Pull Request on Codecov

76.52% (+0.04%) compared to 173ffac

Details

Codecov Report

❌ Patch coverage is 99.04306% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.52%. Comparing base (173ffac) to head (7b4d22e).

Files with missing lines Patch % Lines
dash-spv/src/sync/filters/manager.rs 99.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #958      +/-   ##
==========================================
+ Coverage   76.47%   76.52%   +0.04%     
==========================================
  Files         329      329              
  Lines       80353    80562     +209     
==========================================
+ Hits        61453    61648     +195     
- Misses      18900    18914      +14     
Files with missing lines Coverage Δ
dash-spv/src/sync/filters/batch.rs 97.72% <100.00%> (+0.12%) ⬆️
dash-spv/src/sync/filters/sync_manager.rs 100.00% <100.00%> (ø)
dash-spv/src/sync/filters/manager.rs 97.87% <99.00%> (-0.08%) ⬇️

... and 7 files with indirect coverage changes