Skip to content

refactor(dash-spv): network module rewrite - #902

Open
ZocoLini wants to merge 6 commits into
devfrom
refactor/network-mod
Open

refactor(dash-spv): network module rewrite#902
ZocoLini wants to merge 6 commits into
devfrom
refactor/network-mod

test(dash-spv): drop stale mempool events and the racy mid-rescan wait

748816f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 24, 2026 in 0s

78.82% (+0.04%) compared to ec2e4f9

View this Pull Request on Codecov

78.82% (+0.04%) compared to ec2e4f9

Details

Codecov Report

❌ Patch coverage is 91.99507% with 130 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.82%. Comparing base (ec2e4f9) to head (748816f).

Files with missing lines Patch % Lines
dash-spv/src/network/peer.rs 84.83% 64 Missing ⚠️
dash-spv/src/network/discovery.rs 48.97% 25 Missing ⚠️
dash/src/network/message.rs 83.33% 12 Missing ⚠️
key-wallet-manager/src/matching.rs 66.66% 6 Missing ⚠️
dash-spv/src/main.rs 0.00% 3 Missing ⚠️
dash-spv/src/sync/mempool/manager.rs 97.36% 3 Missing ⚠️
dash-spv/src/sync/block_headers/manager.rs 98.11% 2 Missing ⚠️
dash-spv/src/sync/blocks/pipeline.rs 94.87% 2 Missing ⚠️
dash-spv/src/sync/filter_headers/manager.rs 96.61% 2 Missing ⚠️
dash-spv/src/sync/filters/pipeline.rs 98.00% 2 Missing ⚠️
... and 9 more
Additional details and impacted files 
@@            Coverage Diff             @@
##              dev     #902      +/-   ##
==========================================
+ Coverage   78.78%   78.82%   +0.04%     
==========================================
  Files         304      294      -10     
  Lines       81331    79072    -2259     
==========================================
- Hits        64079    62332    -1747     
+ Misses      17252    16740     -512
Files with missing lines Coverage Δ
dash-spv-ffi/src/callbacks.rs 80.91% <100.00%> (-1.18%) ⬇️
dash-spv-ffi/src/client.rs 42.28% <100.00%> (ø)
dash-spv/src/client/core.rs 58.82% <ø> (ø)
dash-spv/src/client/event_handler.rs 93.89% <100.00%> (-0.12%) ⬇️
dash-spv/src/client/events.rs 100.00% <100.00%> (ø)
dash-spv/src/client/lifecycle.rs 92.15% <100.00%> (+1.24%) ⬆️
dash-spv/src/client/transactions.rs 79.48% <100.00%> (-0.52%) ⬇️
dash-spv/src/lib.rs 46.66% <ø> (ø)
dash-spv/src/network/manager.rs 91.59% <ø> (+10.23%) ⬆️
dash-spv/src/storage/mod.rs 89.23% <ø> (ø)
... and 36 more

... and 18 files with indirect coverage changes

View more details on Codecov