[ZocoLini]

• Clippy also runs with default features, with and without tests, so dead code only the tests or a feature use fails it. Fixes the one it finds: missing_work_block_list_requests is now #[cfg(test)].
• The sanitizer path filters named dashcore/ and dashcore_hashes/, which don't exist, and missed the crates the sanitized ones depend on. That's how feat(hashes)!: switch proof of work backend to dash-pow, bump Base SDK crates to dashpay/base-sdk@addedfa #1214 merged without running it.

🤖 Generated with Claude Code

PR Hygiene · 8b0622a

• Bots — coderabbitai skipped after the window
• Self-review — post /self-reviewed
• Build failed
• Approvals
  • github (.github/workflows/sanitizer.yml) — ktechmidas or shumkov
  • files with no dedicated owner (contrib/run_clippy.py) — QuantumExplorer or xdustinface
  • dash-spv (dash-spv/src/sml_engine.rs) — QuantumExplorer or xdustinface

When every merge requirement is met, the PR Hygiene check passes. Reviewer limits do not block merging; other required GitHub checks and protections still apply.

[github-actions]

Waiting for bot review — coderabbitai not yet. Wait for the missing reviews, or a writer can post /skip-bots to proceed without them; blocking findings still need addressing.
Full checklist in the description.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Source mode: Auto
• Repository: dashpay/rust-dashcore
• Branch: ci/fix-lint-gaps
• File: .coderabbit.yaml
• Commit: 6371a8e
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Advanced
• Run ID: e606bb42-0712-46cf-a1dd-f911ba3d391c

📥 Commits

Reviewing files that changed from the base of the PR and between ec2e4f9 and 6371a8e.

📒 Files selected for processing: 2

• contrib/run_clippy.py
• dash-spv/src/sml_engine.rs

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

The Clippy script now runs six profiles with different feature and target settings. The missing_work_block_list_requests method is now compiled only in test builds.

Changes: Clippy profile configurations

Layer / File(s)	Summary
Clippy profile selection contrib/run_clippy.py	The script replaces two generic debug and release profiles with six profiles: all features and targets, all targets, and defaults, each in debug and release modes. The shared arguments no longer always include --all-features and --all-targets.

Test-only method scope

Layer / File(s)	Summary
Gate method to test builds dash-spv/src/sml_engine.rs	The missing_work_block_list_requests method now has a #[cfg(test)] attribute.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Possibly related PRs

• dashpay/rust-dashcore#1211: Changes the same method’s return type and its use as a public test utility.
• dashpay/rust-dashcore#1212: Updates the same method and adds the readable request path.

Suggested reviewers: xdustinface, quantumexplorer

Merge Risk: ⚪ Minimal · up to 6371a

The change appears mergeable after normal checks. No affected external caller or broken Clippy profile has been identified.

Pre-merge checks: 4 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Title check		The title accurately describes the Clippy dead-code change, but it also claims a sanitizer path filter fix that is not present in the provided changeset.	Remove the unsupported sanitizer path filter claim, or include the corresponding sanitizer path filter changes in the pull request.

Passed checks: 4 passed

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage		Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches: 💡 1

🛠️ Fix failing CI checks: 💡

• Commit to this branch
• Create a new PR

📝 Generate docstrings

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

Bots are done — your move: post /self-reviewed.
Full checklist in the description.

[github-actions]

Waiting for bot review — coderabbitai not yet. Wait for the missing reviews, or a writer can post /skip-bots to proceed without them; blocking findings still need addressing.
Full checklist in the description.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.84%. Comparing base (ec2e4f9) to head (8b0622a).

Additional details and impacted files

@@            Coverage Diff             @@
##              dev    #1216      +/-   ##
==========================================
+ Coverage   78.78%   78.84%   +0.05%     
==========================================
  Files         304      304              
  Lines       81331    81331              
==========================================
+ Hits        64079    64126      +47     
+ Misses      17252    17205      -47     

Flag	Coverage Δ
core	77.75% <ø> (ø)
ffi	50.55% <ø> (+0.68%)	⬆️
rpc	52.05% <ø> (ø)
spv	92.35% <ø> (-0.12%)	⬇️
wallet	82.54% <ø> (ø)

Files with missing lines	Coverage Δ
dash-spv/src/sml_engine.rs	97.25% <ø> (ø)

... and 22 files with indirect coverage changes

[github-actions]

@coderabbitai review

No review for 8b0622ac yet, so PR Hygiene is asking once. If nothing arrives, the requirement is dropped for this commit and the pull request is labelled bot-review-skipped.

[github-actions]

Bots are done — your move: post /self-reviewed.
Full checklist in the description.