Skip to content

feat(dash-spv)!: check masternode list diffs against the block coinbase - #1206

Draft
shumkov wants to merge 9 commits into
shumkov/masternode-sync-livenessfrom
shumkov/mnlistdiff-coinbase-port
Draft

shumkov wants to merge 9 commits into
shumkov/masternode-sync-livenessfrom
shumkov/mnlistdiff-coinbase-port

feat(dash): check quorum roots of lists with unknown quorum types

67b2185
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 27, 2026 in 0s

No report found to compare against

View this Pull Request on Codecov

No report found to compare against

Details

Codecov Report

❌ Patch coverage is 98.63211% with 19 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (shumkov/masternode-sync-liveness@aa4630b). Learn more about missing BASE report.

Files with missing lines Patch % Lines
dash/src/sml/masternode_list/merkle_roots.rs 98.30% 8 Missing ⚠️
dash/src/network/message_sml.rs 96.84% 7 Missing ⚠️
dash-spv/src/sml_engine.rs 98.72% 4 Missing ⚠️
Additional details and impacted files
@@                         Coverage Diff                         @@
##             shumkov/masternode-sync-liveness    #1206   +/-   ##
===================================================================
  Coverage                                    ?   79.80%           
===================================================================
  Files                                       ?      304           
  Lines                                       ?    83621           
  Branches                                    ?        0           
===================================================================
  Hits                                        ?    66732           
  Misses                                      ?    16889           
  Partials                                    ?        0           
Files with missing lines Coverage Δ
dash-spv/src/sml_engine/helpers.rs 99.43% <100.00%> (ø)
dash-spv/src/storage/masternode.rs 99.61% <100.00%> (ø)
dash-spv/src/sync/masternodes/sync_manager.rs 98.42% <100.00%> (ø)
dash/src/merkle_tree/block.rs 92.43% <100.00%> (ø)
dash/src/sml/error.rs 0.00% <ø> (ø)
dash/src/sml/masternode_list/apply_diff.rs 95.16% <100.00%> (ø)
dash/src/sml/masternode_list/builder.rs 84.21% <100.00%> (ø)
dash/src/sml/masternode_list/from_diff.rs 92.20% <100.00%> (ø)
dash-spv/src/sml_engine.rs 97.49% <98.72%> (ø)
dash/src/network/message_sml.rs 95.45% <96.84%> (ø)
... and 1 more