[shumkov]

Issue being fixed or feature implemented

Rust workspace tests fail on v5.0-dev since #4993 (run 39379768914 on 5303dd3):

action_fee_tests::should_refuse_a_base_carrying_an_agreement_at_protocol_version_13
expected the batch to be inactive before protocol version 14, got UnpaidConsensusError(BasicError(StateTransitionNotActiveError { state_transition_type: "DocumentsBatch([Create])", current_protocol_version: 13, required_protocol_version: 14 }))

The test (#4858) asserted that a batch whose document base is version 2 is refused at protocol version 13 with an internal "not active" error. #4993 deliberately turned that refusal into an unpaid StateTransitionNotActiveError consensus error. Both PRs were green on their own; together the test's expectation is stale.

What was done?

The same stale expectation was in eight tests in total (found with a full cargo test -p drive-abci --lib --no-fail-fast, since CI's nextest stops at the first failure): action fees (batch with a version 2 base), contract fee claim, contract user moderation (block result and check_tx), identity key limits update, identity top-up from the shielded pool, shield from identity, token pool-paid transitions, and identity create with a group-bound key. Each now expects the unpaid StateTransitionNotActiveError for its transition type; check_tx now returns it as a consensus error rather than failing. The unpaid / unchanged-state checks stay. Test-only change.

For the first test: the test now expects UnpaidConsensusError(BasicError::StateTransitionNotActiveError) for a DocumentsBatch, current protocol version 13, required 14. The check that the user's credits are untouched (the refusal is unpaid) is unchanged. Test-only change.

How Has This Been Tested?

• ✖ on 5303dd3 (CI run 39379768914) and 8 failures in a full local drive-abci --lib run on ff88756; ✔ with this change.
• cargo test -p drive-abci --lib action_fee_tests: 29 passed.
• cargo fmt --all -- --check, cargo clippy -p drive-abci --tests -- -D warnings: clean.

Breaking Changes

None.

Checklist:

• I have performed a self-review of my own code
• I have added or updated relevant unit/integration/functional/e2e tests

🤖 Generated with Claude Code

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Repository: dashpay/platform/.coderabbit.yaml
• Review profile: CHILL
• Plan: Advanced
• Run ID: dadb7761-8cee-4921-adf8-5161ce6370e8

📥 Commits

Reviewing files that changed from the base of the PR and between ff88756 and 30977ef.

📒 Files selected for processing: 1

• packages/rs-drive-abci/src/execution/validation/state_transition/state_transitions/batch/tests/document/action_fees.rs

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

The protocol-version 13 document action-fee test now checks for an unpaid StateTransitionNotActiveError and verifies its transition type and protocol versions.

Changes: Document transition test

Layer / File(s)	Summary
Assert structured inactive-transition error packages/rs-drive-abci/src/execution/validation/state_transition/state_transitions/batch/tests/document/action_fees.rs	The test imports BasicError and ConsensusError. It checks the inactive-transition error type, transition type, current protocol version, and required protocol version.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Other

Suggested reviewers: quantumexplorer

Merge Risk: ⚪ Minimal · up to 30977

The test-only update is mergeable with no identified production impact.

Pre-merge checks: 5

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly identifies the test change and the expected not-active consensus error for a version 2 base at protocol version 13.
Docstring Coverage		Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

Waiting for bot review — coderabbitai ✓ · thepastaclaw not yet. Wait for the missing reviews, or a writer can post /skip-bots to proceed without them; blocking findings still need addressing.
Full checklist in the description.

[thepastaclaw]

🔍 Review in progress — actively reviewing now (commit 30977ef) · triage: low
████████████████████ 98% · finishing up · running for 1 h 34 min
✅ triage → ✅ Phase 1 → ✅ verify 1 → ✅ gate → ⏳ Phase 2 (0/4 lanes) → ▫️ verify 2 → ▫️ publish
_{Estimated from recent reviews of this tier · updated 12:59 UTC · live progress}