Repository navigation
test(platform-wallet-storage): move the Core transaction rows test into the integration binary - #5415
Conversation
…to the integration binary #5392 added tests/persisted_core_transactions.rs as its own test crate, loading the shared helpers with `mod common;`. #5397, merged after it, moved those helpers to tests/integration/common and built the integration tests as one binary, so the file's `mod common;` no longer resolves: `cargo fmt --check --all` fails on v5.0-dev and the test does not compile. Move the file into tests/integration as a module of that binary, declared in main.rs, using `crate::common` like the other modules, with its fixture read from ../fixtures. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 44 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Waiting for bot review — coderabbitai not yet · thepastaclaw not yet. Wait for the missing reviews, or a writer can post |
|
🕓 Review not started yet because the new head is waiting for the 30-minute push debounce.
Commit a1425b9. Normal review starts when eligible; priority review starts as soon as a slot is available. |
Basic explanation
What this does: Two pull requests merged into
v5.0-devtoday without seeing each other. One added a wallet-storage test file, and the other moved the shared test helpers that file loads. The file now points at helpers that are no longer there, so the Rust formatting check fails onv5.0-devand on every pull request based on it. This moves the file next to the helpers, as the second pull request did with every other test file.Value: The "Rust workspace tests / Tests" job passes its formatting step again, and the test compiles and runs.
Risks: None. Test-only: one file moved, two lines in it changed, one line added to the test binary's module list.
Issue being fixed or feature implemented
packages/rs-platform-wallet-storage/tests/persisted_core_transactions.rs, a test crate of its own that loads the shared helpers withmod common;fromtests/common/.tests/common/totests/integration/common/and built the integration tests as one binary, declared intests/integration/main.rs.Before (
v5.0-devat 3375427):After:
What was done?
tests/persisted_core_transactions.rstotests/integration/persisted_core_transactions.rsand declared it intests/integration/main.rs.mod common;becameuse crate::common;, as in the other modules, and the fixture is read withinclude_str!("../fixtures/core_transaction_rows.txt"). The fixture stays intests/fixtures/.How Has This Been Tested?
cargo fmt --check --all: passes.cargo test -p platform-wallet-storage --test integration -- persisted_core_transactions: 1 passed.cargo clippy -p platform-wallet-storage --tests: no new warnings.Breaking Changes
None.
Checklist:
For repository code-owners and collaborators only
🤖 Generated with Claude Code
PR Hygiene ·
a1425b9/skip-botsproceeds without the ones not yet reported/self-reviewedwallet-storage(packages/rs-platform-wallet-storage/tests/integration/main.rs,packages/rs-platform-wallet-storage/tests/integration/persisted_core_transactions.rs,packages/rs-platform-wallet-storage/tests/persisted_core_transactions.rs) — lklimekWhen every merge requirement is met, the
PR Hygienecheck passes. Reviewer limits do not block merging; other required GitHub checks and protections still apply.