Skip to content

test(platform-wallet-storage): move the Core transaction rows test into the integration binary - #5415

Merged
QuantumExplorer merged 1 commit into
v5.0-devfrom
fix/wallet-storage-core-tx-test-module
Oct 13, 2026
Merged

QuantumExplorer merged 1 commit into
v5.0-devfrom
fix/wallet-storage-core-tx-test-module

Conversation

@QuantumExplorer

@QuantumExplorer QuantumExplorer commented Oct 13, 2026 •

Copy link
Copy Markdown
Member

Basic explanation

What this does: Two pull requests merged into v5.0-dev today without seeing each other. One added a wallet-storage test file, and the other moved the shared test helpers that file loads. The file now points at helpers that are no longer there, so the Rust formatting check fails on v5.0-dev and on every pull request based on it. This moves the file next to the helpers, as the second pull request did with every other test file.

Value: The "Rust workspace tests / Tests" job passes its formatting step again, and the test compiles and runs.

Risks: None. Test-only: one file moved, two lines in it changed, one line added to the test binary's module list.

Issue being fixed or feature implemented

Before (v5.0-dev at 3375427):

$ cargo fmt --check --all
Error writing files: failed to resolve mod `common`: .../rs-platform-wallet-storage/tests/common.rs does not exist

After:

$ cargo fmt --check --all                       # exit 0
$ cargo test -p platform-wallet-storage --test integration -- persisted_core_transactions
test persisted_core_transactions::should_decode_and_re_encode_every_stored_transaction_row_unchanged ... ok

What was done?

  • Moved tests/persisted_core_transactions.rs to tests/integration/persisted_core_transactions.rs and declared it in tests/integration/main.rs.
  • In the file: mod common; became use crate::common;, as in the other modules, and the fixture is read with include_str!("../fixtures/core_transaction_rows.txt"). The fixture stays in tests/fixtures/.

How Has This Been Tested?

  • cargo fmt --check --all: passes.
  • cargo test -p platform-wallet-storage --test integration -- persisted_core_transactions: 1 passed.
  • cargo clippy -p platform-wallet-storage --tests: no new warnings.

Breaking Changes

None.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

🤖 Generated with Claude Code

PR Hygiene · a1425b9

  • Bots — coderabbitai not yet · thepastaclaw not yet — /skip-bots proceeds without the ones not yet reported
  • Self-review — post /self-reviewed
  • Reviewer requests paused — your 5 review slots are occupied; this PR is excluded from reviewers' queues. Required approvals still count without a slot.
  • Build running
  • Approvals
    • wallet-storage (packages/rs-platform-wallet-storage/tests/integration/main.rs, packages/rs-platform-wallet-storage/tests/integration/persisted_core_transactions.rs, packages/rs-platform-wallet-storage/tests/persisted_core_transactions.rs) — lklimek

When every merge requirement is met, the PR Hygiene check passes. Reviewer limits do not block merging; other required GitHub checks and protections still apply.

…to the integration binary

#5392 added tests/persisted_core_transactions.rs as its own test crate,
loading the shared helpers with `mod common;`. #5397, merged after it,
moved those helpers to tests/integration/common and built the
integration tests as one binary, so the file's `mod common;` no longer
resolves: `cargo fmt --check --all` fails on v5.0-dev and the test does
not compile.

Move the file into tests/integration as a module of that binary, declared
in main.rs, using `crate::common` like the other modules, with its
fixture read from ../fixtures.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 44 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Repository: dashpay/platform/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 1c2f2094-1f32-4d0f-bbc6-a5e101a66768
📥 Commits

Reviewing files that changed from the base of the PR and between 3375427 and a1425b9.

📒 Files selected for processing (2)
  • packages/rs-platform-wallet-storage/tests/integration/main.rs
  • packages/rs-platform-wallet-storage/tests/integration/persisted_core_transactions.rs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added this to the v5.0.0 milestone Oct 13, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Waiting for bot review — coderabbitai not yet · thepastaclaw not yet. Wait for the missing reviews, or a writer can post /skip-bots to proceed without them; blocking findings still need addressing.
Full checklist in the description.

@github-actions github-actions Bot added the waiting-bots Waiting for the review bots to report on this head label Oct 13, 2026
@QuantumExplorer
QuantumExplorer merged commit 22381ca into v5.0-dev Oct 13, 2026
20 of 21 checks passed
@QuantumExplorer
QuantumExplorer deleted the fix/wallet-storage-core-tx-test-module branch October 13, 2026 14:26
@thepastaclaw

Copy link
Copy Markdown
Collaborator

🕓 Review not started yet because the new head is waiting for the 30-minute push debounce.

  • Request normal review — click when the PR is ready for review.
  • Request priority review — click to move this review to the front of the queue.

Commit a1425b9. Normal review starts when eligible; priority review starts as soon as a slot is available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-bots Waiting for the review bots to report on this head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants