[QuantumExplorer]

Issue being fixed or feature implemented

Split out of #4616. That PR bundles the DashPay contract field, the wallet's dedicated tip accounts, persistence migrations, FFI, and the Swift/Kotlin example flows. This PR carries only the contract change so it can land first; the wallet and mobile work stays in #4616 and will be rebased on top of it.

Adds an optional shieldedAddress property to the DashPay profile document so a user can publish a reusable Orchard receiving address and get paid by username. Follows the transparent corePaymentAddress / platformPaymentAddress fields from #4380 and the 43-byte raw address format in dashpay/dips#188.

What was done?

• profile.shieldedAddress on DashPay contract v2 (protocol version 14) at position 7: a 43-byte array, the 11-byte diversifier followed by the 32-byte diversified transmission key. Consensus enforces only the byte length; clients validate that the bytes decode as an Orchard address before paying. No data trigger, since unlike the transparent fields there is no type byte to check.
• Protocol 13 to 14 upgrade tests assert the field is absent before transition_to_version_14 and present after it, in both the in-place transition test and the full upgrade walk.
• New shielded_profile_schema_tests in drive-abci: lengths 0, 42, 43 and 44 bytes validate only at protocol 14 with exactly 43 bytes; a non-byte value is rejected; a legacy displayName-only profile stays valid on both versions.
• Deterministic pins recomputed for the larger PV14 contract: contract create/update processing fees in the check-tx tests, document deletion and replacement fees, the replacement tests' expected profile strings, and the PV14 genesis root hash.
• Comments in dashpay-contract v2 and SYSTEM_DATA_CONTRACT_VERSIONS_V3 list the new field.

How Has This Been Tested?

Local, targeted (CI runs the full suites):

• cargo test -p dashpay-contract
• cargo test -p drive --test deterministic_root_hash: 2 passed
• cargo test -p drive-abci --lib -- check_tx::v0::tests::data_contract document:: protocol_change shielded_profile_schema_tests dashpay: 209 passed (12 check-tx, 177 batch document, 20 protocol upgrade including the new boundary test)
• cargo fmt --check on the touched crates

Breaking Changes

Changes the protocol 14 DashPay v2 contract bytes and the matching deterministic fee and root-hash baselines. Protocol 14 is unreleased; this must not be applied as an unversioned change to an activated contract. Historical (protocol 13 and earlier) roots are unchanged.

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated relevant unit/integration/functional/e2e tests
• I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
• I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

• I have assigned this pull request to a milestone

🤖 Generated with Claude Code

[coderabbitai]

Warning

Review limit reached

Next included review available in 35 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: d3b7feb3-8d2b-4e0f-b6e5-cd858e09c1ce

📥 Commits

Reviewing files that changed from the base of the PR and between ffb6e53 and c8157f3.

📒 Files selected for processing (8)

• packages/dashpay-contract/schema/v2/dashpay.schema.json
• packages/dashpay-contract/src/v2/mod.rs
• packages/rs-drive-abci/src/execution/check_tx/v0/mod.rs
• packages/rs-drive-abci/src/execution/platform_events/protocol_upgrade/perform_events_on_first_block_of_protocol_change/v0/mod.rs
• packages/rs-drive-abci/src/execution/validation/state_transition/state_transitions/batch/tests/document/deletion.rs
• packages/rs-drive-abci/src/execution/validation/state_transition/state_transitions/batch/tests/document/replacement.rs
• packages/rs-drive/tests/deterministic_root_hash.rs
• packages/rs-platform-version/src/version/system_data_contract_versions/v3.rs

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[thepastaclaw]

🕓 Queued for automated review — 9th in line, estimated start in ~25 min (commit c8157f3)
Estimated review time once started: ~5 min (two-phase automated review; median of recent runs).

• Request priority review — click to move this review to the front of the queue.

[codecov]

Codecov Report

❌ Patch coverage is 71.69811% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.73%. Comparing base (7f80937) to head (c8157f3).
⚠️ Report is 1 commits behind head on v4.2-dev.

Files with missing lines	Patch %	Lines
...ges/rs-drive-abci/src/execution/check_tx/v0/mod.rs	0.00%	12 Missing ⚠️
...events_on_first_block_of_protocol_change/v0/mod.rs	92.68%	3 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##           v4.2-dev    #4768      +/-   ##
============================================
- Coverage     84.54%   82.73%   -1.82%     
============================================
  Files          2832     2832              
  Lines        382305   390229    +7924     
============================================
- Hits         323235   322854     -381     
- Misses        59070    67375    +8305     

Components	Coverage Δ
dpp	86.58% <ø> (-0.68%)	⬇️
drive	84.54% <ø> (+0.21%)	⬆️
drive-abci	81.29% <71.69%> (-2.00%)	⬇️
sdk	∅ <ø> (∅)
dapi-client	∅ <ø> (∅)
platform-version	∅ <ø> (∅)
platform-value	66.80% <ø> (-26.12%)	⬇️
platform-wallet	∅ <ø> (∅)
drive-proof-verifier	39.21% <ø> (ø)

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[QuantumExplorer]

Reviewed