Repository navigation
Move off foregroundColor / cornerRadius / overlay(_:alignment:), which are deprecated in a future SDK #28
Description
Summary
With the iOS 18 / macOS 15 floor from #15, the library still uses SwiftUI APIs that Apple marks "deprecated in a future version". They don't produce warnings yet, but they will in a future SDK:
| API | Count in Sources/ |
Replacement |
|---|---|---|
.foregroundColor(_:) |
~90 | .foregroundStyle(_:) |
.cornerRadius(_:) |
7 | .clipShape(.rect(cornerRadius:)) (with style: .continuous wherever the design calls for it) |
.overlay(_:alignment:) |
~12 (DashButton, AddressFieldView, ConverterCard, ConverterArrowBadge, SimpleSelect, NavigationBarCircleIcon, the FrameReader preview, …) |
.overlay(alignment:content:) |
#15 migrated only the code it rewrote, and the rest is deliberately left for a separate PR. It is a mechanical change, but it touches almost every component, so it needs its own visual check.
Notes
foregroundStyleonTextinsideTextconcatenation needs care: check the places that concatenateText..cornerRadiusdraws a non-continuous corner. Keep that look, or switch deliberately to.continuouswhere the design uses it.- After the migration,
swift buildshould have no deprecation warnings on the latest SDK.
Activity
[-]Move off foregroundColor / cornerRadius, which are deprecated in a future SDK[/-][+]Move off foregroundColor / cornerRadius / overlay(_:alignment:), which are deprecated in a future SDK[/+]