Http: honor Content-Encoding and expose decodeInputStream - #114
Closed
anjeshshrestha wants to merge 1 commit into
Closed
anjeshshrestha wants to merge 1 commit into
anjeshshrestha wants to merge 1 commit into
Conversation
anjeshshrestha
commented
Oct 1, 2026
anjeshshrestha
commented
Contributor
- Use readNBytes for the gzip magic check; a plain read() may return a single byte on a partial network read and skip decompression
- Decompress when Content-Encoding says gzip or deflate, not only when the gzip magic bytes are present
- Add static Http.decodeInputStream(HttpURLConnection) so callers that work with getConnection() directly (e.g. to inspect the final URL) get the same decoding
- Leave empty bodies untouched instead of throwing EOFException
- Use readNBytes for the gzip magic check; a plain read() may return a single byte on a partial network read and skip decompression - Decompress when Content-Encoding says gzip or deflate, not only when the gzip magic bytes are present - Add static Http.decodeInputStream(HttpURLConnection) so callers that work with getConnection() directly (e.g. to inspect the final URL) get the same decoding - Leave empty bodies untouched instead of throwing EOFException
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.