Repository navigation
test(mac): 展示测试改查真实编辑器分组，并补齐 usage-termination 的更新源文件 - #140
Merged
Merged
Conversation
PresentationTests still read AdjustmentParameter.photoTools, a list only the test used. After 0.9 added black point, white point, vibrance, clarity and dehaze it no longer matched the editor, so the macOS model job stopped there and skipped the suites after it. The test now walks EditorAdjustmentGroup, the definition the adjustment dock renders, and photoTools is removed. usage-termination.sh also compiles the desktop update sources that MacGeometryWindowGuard needs. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This was referenced Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景
release/0.9.0（031dc1c8，#138）和 #139 的macOS full (arm64, all)都在RawLabMac/tests/presentation.sh --models-only失败：这个任务遇错即停，所以排在后面的
mac-viewing.sh、usage-model.sh、usage-termination.sh一直没有运行。补跑后发现usage-termination.sh也无法编译（cannot find type 'DesktopUpdateController'）。两处都是测试没跟上 0.9 的改动，产品代码没有问题。改动
PresentationTests.swift：不再检查只有测试在用的AdjustmentParameter.photoTools，改为遍历编辑器真实渲染的EditorAdjustmentGroup.tools（AdjustmentDock直接读取这套定义）。保留原有意图：vignette 和 grain 存在；除 strength、rawNoiseReduction、tint 外每个参数恰好出现一次；白平衡只有一个工具；统一降噪取代旧 RAW 降噪；每个工具都有系统图标。黑场、白场、鲜艳度、清晰度、去朦胧都有入口。AdjustmentTypes.swift：删除已无引用的photoTools。usage-termination.sh：补上MacGeometryWindowGuard依赖的 5 个桌面更新源文件，与update-install.sh的清单一致。界面行为不变。
验证
源码：本分支 HEAD，基于
origin/release/0.9.0031dc1c。macOS（M3 Max，Xcode MacOSX SDK），核心链接已构建的本地核心。依次运行 CI
in_suite model的 8 个入口和control-groups.sh，全部通过：bash RawLabMac/tests/control-groups.shbash RawLabMac/tests/batch-export.shbash Shared/tests/batch-selection.shbash RawLabMac/tests/batch-selection-model.shbash RawLabMac/tests/edit-model.shbash RawLabMac/tests/adjustment-history-model.shbash RawLabMac/tests/presentation.sh --models-only（含mac-viewing.sh）bash RawLabMac/tests/usage-model.shbash RawLabMac/tests/usage-termination.sh（default、rum、local 三种模式）未覆盖
--models-only的完整presentation.sh，其中的mac-canvas-input.sh会启动图形界面。🤖 Generated with Claude Code