Repository navigation
Fix the extended search mode - #1182
Open
CyrilB1531 wants to merge 1 commit into
Open
CyrilB1531 wants to merge 1 commit into
CyrilB1531 wants to merge 1 commit into
Conversation
In Extended mode the search text was never converted: the converted
text was discarded and the Finder searched for the raw "\t", "\n"...
Find, Count, Find All, Mark and Replace now search for the converted
text.
The conversion is now done in a single pass, so an escaped backslash
works ("\\t" finds the text "\t"), "\0" gives a null character instead
of an empty string, and unknown or incomplete sequences are kept as is.
It also supports the character codes \xHH, \uHHHH, \oNNN, \dNNN and
\bNNNNNNNN.
Matches are now searched in the target instead of with SCI_FINDTEXT,
which takes a null terminated string, so null characters can be found
by Count, Find All, Mark and Replace All as well.
Fixes dail8859#1181
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Extended mode the search text was never converted: the converted text was discarded and the Finder searched for the raw "\t", "\n"... Find, Count, Find All, Mark and Replace now search for the converted text.
The conversion is now done in a single pass, so an escaped backslash works ("\t" finds the text "\t"), "\0" gives a null character instead of an empty string, and unknown or incomplete sequences are kept as is. It also supports the character codes \xHH, \uHHHH, \oNNN, \dNNN and \bNNNNNNNN.
Matches are now searched in the target instead of with SCI_FINDTEXT, which takes a null terminated string, so null characters can be found by Count, Find All, Mark and Replace All as well.
Fixes #1181