Repository navigation
Conversation
On macOS, the Hangul IME sends two events that were mishandled: - Deleting the last jamo of a composition is reported as a commit of "\b", which was inserted as a literal BS character. - Typing an ASCII character (e.g. "!") while a syllable is being composed commits only that character, and the composing syllable was lost. Handle both cases, guarded by Q_OS_MACOS so other platforms are unaffected. Hanja and kana conversion are not affected.
Owner
|
Appreciate the PR but everything under |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On macOS, typing Korean (Hangul) with the system IME has two problems:
character into the document.
!) while a syllable is being composedreplaces the composing syllable instead of keeping it.
Cause
I logged
QInputMethodEventon macOS (Qt 6.12, built-in Korean IME):commit="\b".!arrives ascommit="!"whilepreedit="아"is pending; thecomposition is undone and never committed.
Changes
The behavior changes are guarded by
Q_OS_MACOS, so other platformsare unaffected. (A new member variable and a local copy of the commit
string are the only code outside the guard; they do not change behavior.)
"\b"commit.pending, keep the preedit. Hanja / kana conversion should not be
affected, since those commits are not a single ASCII char.
Testing
deleted mid-composition, typed symbols/digits right after a syllable.
All behave as expected.
macOS.