Repository navigation
Fix connect penalty counts always showing 0 (1.9.1) - #296
Merged
Merged
Conversation
The admin notification on player connect always reported 0 bans, gags, mutes and silences. - MuteManager.GetPlayerMutes ran GetRetrieveMutesQuery (the unmute id lookup, which needs @pattern/@muteType) instead of GetMuteStatsQuery. The query threw, the catch returned (0,0,0), so mute counts were always 0. - CacheManager.GetPlayerBansBySteamId read _steamIdIndex, which only holds ACTIVE bans. Anyone with an active ban is kicked before the message is sent, so the count was always 0. It now counts all of the player's bans in _banCache (expired/unbanned included). The connect message is its only caller; the ban check still uses the active index.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A server owner reported that the admin notification on player connect (
sa_admin_penalty_info) always shows 0 penalties. Bans, gags, mutes and silences were all always 0.Causes and fixes
MuteManager.GetPlayerMutesranGetRetrieveMutesQuery(the unmute id lookup, which needs@pattern/@muteType) instead ofGetMuteStatsQuery. The query threw, thecatchreturned(0,0,0), and the counts were always 0. It now usesGetMuteStatsQuery.CacheManager.GetPlayerBansBySteamIdread_steamIdIndex, which only holds ACTIVE bans. A player with an active ban is kicked before the message is sent, so the count was always 0. It now counts all of the player's bans in_banCache, expired and unbanned included. The connect message is the only caller; the ban check still uses the active-only index, so kick behavior is unchanged.Version bumped to 1.9.1 (
VERSION,ModuleVersion).Testing