Repository navigation
chore(deps): update .node-version & .nvmrc to Node.js 26.12.1 - #1946
Merged
Merged
Conversation
Convert workflow to use .node-version: .github/workflows/main.yml .github/workflows/check-dist.yml Update @types/node to 26.6.5
MikeMcC399
force-pushed
the
update/node-26-default
branch
from
October 26, 2026 12:03
dc1b7cd to
eb0966d
Compare
mschile
approved these changes
Oct 26, 2026
|
🎉 This PR is included in version 7.4.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Situation
Inconsistent default Node.js
After merge of PR #1943, the repo is running in mixed Node.js versions and there is a mismatch between the updated workflows and the definition in .node-version and .nvmrc.
These versions are managed by Renovate, which keeps them at the latest LTS version, restricted however by the
"minimumReleaseAge": "7 days"setting to guard against supply-chain attacks.Renovate does not currently interpret the security key in https://nodejs.org/download/release/index.json and is unable to make an exception for security updates.
On Oct 28, 2026, Node.js plans to promote Node.js 26 to LTS (Long Term Support) status and to release Node.js 26.13.0 as a re-tagged version of the security release Node.js 26.12.1 from Oct 21, 2026.
Divergence of LTS from node24
After the Node.js promotion, and expiry of the 7 day
minimumReleaseAgeperiod, Renovate will generate PRs to update Node.js versions to 26.x. This will cause the exception inmain&check-distto diverge in its major version. It was originally being maintained manually so that it mirrored exactly the same Node.js version as the GitHub runner fornode24. This is no longer practical (due to Renovate) or necessary (nccis now compatible with Node.js 26).Change
The above two separate and related issues happen to coincide. Resolve by bumping to use Node.js 26. Apply this also to
mainandcheck-dist.Update the following to Node.js 26.12.1 as the pre-release of the Node.js 26 LTS version expected on Oct 28, 2026:
Migrate the following workflows to use .node-version consistently:
This establishes the security release Node.js 26.12.1 from Oct 21, 2026 as the default baseline for the repo.
There is no change to the compiled action caused by the Node.js version upgrade. The
distdirectory is identical.Note
Cypress runs in the action using the version of Node.js provided by the GitHub runner. The version in use depends on GitHub's rollout for GitHub-hosted runners or by updates provided to GitHub self-hosted runners, so different repos may be using different Node.js versions.
When Cypress runs in a
cypress/browsersDocker image, the version of Node.js is determined by the version bundled into the image.Examples use the default Node.js version provided by the respective GitHub Actions runner image.
Note
Low Risk
Toolchain and CI configuration only; no runtime action code or dist output changes.
Overview
Aligns the repo on Node.js 26.12.1 by updating
.node-versionand.nvmrcfrom 24.22.0.CI workflows (
main.yml,check-dist.yml) stop pinningnode-version: 24.22.1and instead usesetup-nodewithnode-version-file: '.node-version'plus npm caching. The release job now installs Node the same way beforenpm ciand semantic-release.Dev tooling tracks the bump via
@types/node26.6.5 (and lockfileundici-typesupdates). The PR notes the builtdist/output is unchanged.Reviewed by Cursor Bugbot for commit f8945db. Bugbot is set up for automated code reviews on this repo. Configure here.