Repository navigation
[-] fix first-use setup and YAML argument examples - #867
Open
dajiaohuang wants to merge 3 commits into
Open
dajiaohuang wants to merge 3 commits into
dajiaohuang wants to merge 3 commits into
Conversation
pashagolub
reviewed
Oct 15, 2026
Coverage Report for CI Build 38942744595Coverage increased (+0.04%) to 87.931%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions3 previously-covered lines in 2 files lost coverage.
Coverage Stats
💛 - Coveralls |
Move yaml-format.md chain examples into samples/yaml and pull them in with pymdownx.snippets, so the sample test covers them without regex extraction from Markdown.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Correct a group of runnable documentation/example errors without changing scheduler behavior:
LOGINand initialize the schema with--initbefore callingtimetable.add_job. On a fresh PostgreSQL database the old order fails withschema "timetable" does not exist, and the password-only role cannot log in. Apply the same sequence to the first-chain tutorial (which schedules a nightly, not one-off, job).docker.yml, and stop describinglatestas tracking every master commit.TestYamlExampleParametersparses the shipped YAML and complete README/reference YAML examples, checking SQL/PROGRAM parameter shapes without executing programs or connecting to a database. It fails against the base examples and passes with these corrections.Validation
go vet ./...;git diff --check.Limits: no real/user databases or host PROGRAM jobs were executed. The local Testcontainers integration attempt failed before PostgreSQL startup because Ryuk disappeared before readiness; direct isolated Docker PostgreSQL validation above succeeded. Full Linux/Windows-service integration was not run. Local golangci-lint was built with Go 1.26 and refuses this repository's Go 1.27 target, so lint remains for CI; no language/version constraint was changed.