Repository navigation
fix: virtual edges crash on every real Postgres source (dict_row) - #8
Merged
Merged
Conversation
resolve() does dict(row) on each result, but the postgres branch of _connect opened the connection with psycopg's default tuple row factory, so dict(row) raised on the first real Postgres traversal. 0.1.6's virtual-edge postgres path was effectively broken; the sqlite stand-in tests never exercised it. Fix: open psycopg connections with row_factory=dict_row. Adds a live-postgres regression test (gated on KG_TEST_PG_DSN) that would have caught it. Verified against a real production Postgres warehouse (3.3M-row 13F dataset): multi-hop virtual-edge traversals resolve correctly. version 0.1.6 -> 0.1.7 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug
virtual.resolve()doesdict(row)on each result row. The postgres branch of_connectopened the connection with psycopg's default tuple row factory, sodict(row)raised on the first real Postgres traversal. 0.1.6's virtual-edge Postgres path was effectively broken — the sqlite stand-in tests never exercised the postgres branch, so it shipped.The fix
Open psycopg connections with
row_factory=dict_row. One line.Test
Adds a live-Postgres regression test gated on
KG_TEST_PG_DSN(skips without a writable test DB) that exercises the real psycopg path and would have caught this.Verified against a real production Postgres warehouse (3.3M-row 13F dataset): multi-hop virtual-edge traversals resolve correctly.
version 0.1.6 -> 0.1.7🤖 Generated with Claude Code