Skip to content

feat(frontend): add flashcard keyboard shortcuts - #28

Merged
brennenho merged 3 commits into
mainfrom
brennen/flashcard-keyboard-shortcuts
Oct 16, 2026
Merged

brennenho merged 3 commits into
mainfrom
brennen/flashcard-keyboard-shortcuts

Conversation

@brennenho

@brennenho brennenho commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Use Left/Right arrows to move between flashcards and Up/Down arrows or Space to flip the current card.

Changes

  • Stop at the ends of the deck and show the photo when changing cards.
  • Preserve card focus during navigation and native keyboard activation on buttons.
  • Ignore typing targets and modified shortcuts; prevent scrolling for handled keys.
  • Group the desktop legend into Move and Flip shortcuts using shadcn keycaps and the site's existing colors and typography.

Testing

  • pnpm check: formatting, lint, types, and all 52 tests pass.
  • Browser checks: all four arrows, Space, first/last-card boundaries, focus retention, modified keys, and Space/Enter on focused controls. No browser errors or page scrolling from the arrow shortcuts.
  • Visual checks: desktop legend spacing and mobile layout without overflow or extra tab stops.

@brennenho
brennenho requested a review from a team as a code owner October 16, 2026 21:57
@github-actions
github-actions Bot temporarily deployed to pr-28 October 16, 2026 21:57 Destroyed
@github-actions

github-actions Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Preview deployment

Open preview ↗

Last deployed 2026-10-16T22:08:18Z

Commit Workflow
f2214f7 Run #47 · attempt 1

Fallback preview

@github-actions
github-actions Bot temporarily deployed to pr-28 October 16, 2026 22:02 Destroyed
@github-actions
github-actions Bot temporarily deployed to pr-28 October 16, 2026 22:07 Destroyed
@brennenho
brennenho merged commit 6decfe6 into main Oct 16, 2026
2 checks passed
@brennenho
brennenho deleted the brennen/flashcard-keyboard-shortcuts branch October 16, 2026 22:09
@linear-code

linear-code Bot commented Oct 16, 2026

Copy link
Copy Markdown

CTC-33

This branch was successfully deployed

No deployments
pr-28 — f2214f7f Deployed Oct 16, 2026 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant