Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on csound/csound#3556. Keep this draft until that PR merges and matching npm releases can replace the temporary source checkout in CI.
The current wasm32 double plugins do not match either new engine. Build Chua, image, linear algebra, and STK for both
wasm32-wasip2with float samples andwasm64-wasip2with double samples, using the matching Csound SDKs and source-built Nix toolchains. Wasm64 assets use the-wasm64.wasmsuffix.@csound/pluginsselects wasm32 float to match the default browser engine. The/wasm32and/wasm64entry points each export onepluginsobject. Use/wasm64with the opt-in@csound/browser/wasm64.jsmodule. Static dependencies follow the selected target, and the linear-algebra code now accepts float samples.Each plugin keeps its own Preview 2 file descriptors while following the engine's working directory. Wasm64 plugins embed adapters for their WASI imports, including STK's directory creation. CI pins csound/csound#3556 at
623c6e8fa1f76ed02fc74dfe178061e7b6ef7aec, which includes the loader support and wasm32 browser default.The existing npm dependency versions predate Preview 2. Until matching releases exist,
CSOUND_WASM_PACKAGEselects a built upstream source tree; the README describes that setup and the release steps.