Repository navigation
fix(ci): release plugins from explicit versions and labelled merges - #63
Conversation
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Version validation and release rules .github/scripts/release.py, .github/scripts/test_release.py, .github/actions/check-pr-label/action.yml, package.json |
The new script validates package and lockfile versions, checks release eligibility against merged pull request metadata, and checks version tags. Tests cover these rules and command behavior. The previous label-check action is removed, and the package version changes to 7.0.0. |
Workflow publication and release instructions .github/workflows/plugins_build.yml, README.md, wasm/README.md |
The workflow uses script outputs to gate release publication, checks tags, and creates releases at the triggering commit. The README files document version selection and release steps. Linux and macOS configuration steps group their environment writes. |
Priority:
Estimated code review effort: 3 (Moderate) | ~25 minutes
Change: Bug fix
Sequence Diagram(s)
sequenceDiagram
participant Workflow as plugins_build.yml
participant Script as .github/scripts/release.py
participant API as GitHub API
participant Git as Git tag
participant Release as GitHub release
Workflow->>Script: validate version and release metadata
Script->>API: query merged pull requests
API-->>Script: return pull request metadata
Script-->>Workflow: return version, release, and prerelease outputs
Workflow->>Script: check version tag
Script->>Git: inspect tag target
Workflow->>Release: create release at triggering commit
Possibly related issues
csound/plugins#62: This change implements release tagging and release eligibility for merges ofrelease-labelled pull requests tomain.
Suggested reviewers: vlazzarini
Merge Risk: 
Minimal · up to 57a62
-
The release workflow appears ready to merge after normal checks; no actionable release-blocking issue was identified.
Pre-merge checks: 
4 · 
1
-
Failed checks: 1 warning Passed checks: 4 passedFull details: Docstring Coverage
-
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 14 functions across 2 files. (4 skipped: 4 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
The native workflow currently derives its next version from old
1.0.xtags and can publish on a manual run. Usepackage.jsonas the version source for native tags, asset names, and npm, starting at7.0.0. Check that both lockfile version fields match.Publish only when a push matches the exact merge commit of a
release-labelled PR into the same repository and branch. Releases frommainrequire a stable version; releases fromdeveloprequire a prerelease version. PR builds, manual runs, and unlabelled pushes still build and test.Validation: all 16 release-rule tests pass,
actionlintpasses with ShellCheck enabled, and a read-only check against the latest merged PR returnsrelease=falseas expected. GitHub Actions passed the release-rule job, all four native builds, and the WASM package build and tests. The publish job was skipped as expected for this PR.Refs #62.