Repository navigation
Conversation
A title on the iframe shows as a native tooltip when the modal opens under a resting cursor, and stays until the cursor moves into the frame. aria-label keeps the frame's accessible name without it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
title="SkinCraft 3D viewer". When the modal opens under a resting cursor, Chrome shows that title as a native tooltip over the viewer until the cursor moves into the frame.aria-label, which keeps the frame's accessible name without the tooltip.Validation
npm run checkformatnpm run lintnpm testnpm run buildNote
Low Risk
Single attribute swap on the embed iframe with no behavior or security impact beyond accessibility naming.
Overview
Fixes an unwanted native tooltip when the SkinCraft 3D viewer modal opens with the cursor already over the embed.
The viewer iframe in
skincraft_viewer_modal.tsno longer usestitle="SkinCraft 3D viewer". It now usesaria-label="SkinCraft 3D viewer"so assistive tech still gets an accessible name without Chrome showing that text as a hover tooltip until the pointer moves into the frame.Reviewed by Cursor Bugbot for commit 31a8b0b. Bugbot is set up for automated code reviews on this repo. Configure here.