Repository navigation
refactor: drop image fields from schema types - #419
Merged
Merged
Conversation
The schema endpoint no longer returns images for paints, agents, collectibles and music kits (CSF-1972). None of them were read. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET /api/v1/schemano longer returnsimagefor paints, agents, collectibles and music kits This removes those fields fromItemSchemaso the types match the response.Nothing in the extension read them:
fetch_inspect_info.tsonly uses paint names, wear ranges, rarities and sticker/keychain names. No runtime change.Testing
tsc --noEmit,npm run lint,vitest run(71 tests) andnpm run buildpass.Made with Cursor