feat: support pkg meta file in dependency commands - #393
Draft
fernandezcuesta wants to merge 2 commits into
Draft
fernandezcuesta wants to merge 2 commits into
fernandezcuesta wants to merge 2 commits into
Conversation
Signed-off-by: Jesús Fernández <7312236+fernandezcuesta@users.noreply.github.com>
fernandezcuesta
force-pushed
the
feat/meta-file-dependency-commands
branch
from
September 29, 2026 10:02
4f03126 to
ce1aa13
Compare
fernandezcuesta
commented
Sep 29, 2026
| // FromConfiguration converts Configuration package metadata into a Project | ||
| // whose dependencies are the metadata's package dependencies. | ||
| // | ||
| // TODO: review, we might want this now, or postpone to a separate PR: |
Contributor
Author
There was a problem hiding this comment.
I'm myself not sure about this; I can work a bit more on that, don't drop any information we've today, leave it for later or close the loop now and add support for some project subcommands.
Signed-off-by: Jesús Fernández <7312236+fernandezcuesta@users.noreply.github.com>
fernandezcuesta
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Add support to meta pkg file (
crossplane.yaml) fordependency update-cache,clean-cacheandaddsubcommands.-fno longer defaults tocrossplane-project.yamlonly, it will look forcrossplane.yamlif the former isn't found, fail if none exist.Three new flags
--k8s-version,--schemas-dirand--schema-languages, sincecrossplane.yamlis missing that information. For a project file, it will overridespec.dependencies[].k8s.version,paths.schemasandspec.schemas.languages, respectively.For the
dependency addcommand, k8s, CRD, or API-only dependencies are not supported and will fail when trying to do so with a cfg pkg file (for those, migrate to a Project).--k8s-version generates Kubernetes core API schemas, which dependsOn can't declare.
Fixes #391
I have:
./nix.sh flake checkto ensure this PR is ready for review.[ ] Linked a PR or a docs tracking issue to document this change.[ ] Addedbackport release-x.ylabels to auto-backport this PR.Need help with this checklist? See the cheat sheet.