Repository navigation
Npm nixos integration test - #345
Merged
Merged
Conversation
Exercise the packed npm installer with the actual release binary while keeping the stub fixture as the default fast check. Share archive signing, serving, packing, and installation paths between modes, and assert the installed runtime mode and launcher resolution before running the CLI. Document the real-binary options and verification baseline for the follow-on NixOS VM integration test. Plan: npm-nixos-vm-integration-test (T01) Co-authored-by: SCE <sce@crocoder.dev>
Exercise the packed npm package's postinstall flow in a minimal loopback-only NixOS VM as a non-root user with the release binary. Expose the test only as the opt-in x86_64-linux `npm-nixos-vm` package so normal flake checks do not boot a VM, and verify executable modes, launcher resolution, direct shebang execution, and reported version. Plan: npm-nixos-vm-integration-test (T02) Co-authored-by: SCE <sce@crocoder.dev>
Exercise the real static release binary's npm package in the expensive ci-checks tier on x86_64-linux while keeping normal flake checks unchanged. Link the NixOS VM test into ciChecks and configure Ubuntu PR runners with KVM and the required Nix system features; document the resulting CI contract. Plan: npm-nixos-vm-integration-test (T03) Co-authored-by: SCE <sce@crocoder.dev>
Record completion of the npm-nixos-vm-integration-test plan's T04 work and document the fixture-versus-VM boundary, static-musl rationale, platform coverage, local invocation, and KVM CI requirements. Mark the completed acceptance criteria and task evidence while preserving the outstanding PR CI follow-up. Co-authored-by: SCE <sce@crocoder.dev>
davidabram
force-pushed
the
npm-nixos-integration-test
branch
from
November 3, 2026 19:20
41bdb5e to
a4611a4
Compare
Pass deadlines explicitly to the fake Git runner so error-reporting tests use COMMIT_PATCH_ID_DEADLINE. Keep the 500 ms deadline confined to the Linux timeout test that verifies both Git processes are killed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.