Fix stylistic issues uncovered by cppcheck #638

Activity

1. ludviggunne

   added a commit that references this issue on Apr 3, 2026

   Refs cppcheck-opensource#638: Avoid shadowing arguments

   0ba402f
2. chrchr-github

   added a commit that references this issue on Apr 9, 2026

   Refs cppcheck-opensource#638 Fix stylistic issues uncovered by cppcheck

   550adb6
3. firewave

   added a commit that references this issue on Apr 10, 2026

   Refs #638 Fix stylistic issues uncovered by cppcheck (#643)

   1d0c780
4. ludviggunne

   added 2 commits that reference this issue on Apr 10, 2026

   Refs cppcheck-opensource#638: Avoid shadowing arguments

   50c1de8

   Refs cppcheck-opensource#638: Avoid shadowing arguments

   1737e43
5. firewave

   added a commit that references this issue on Apr 16, 2026

   Refs #638: Avoid shadowing arguments (#639)

   ea9d3cb
6. chrchr-github commented on May 13, 2026

   

   chrchr-github

   on May 13, 2026

   ContributorAuthor

   More actions

   Fixed by #643 and #639
7. chrchr-github

   closed this as completedon May 13, 2026
8. firewave commented on May 27, 2026

   

   firewave

   on May 27, 2026

   Collaborator

   More actions

   Either not all of them have been addressed or there is an unknown issue with unmatchedSuppression because the simplecpp.h suppressions still persist after cppcheck-opensource/cppcheck#8582.
9. chrchr-github commented on May 27, 2026

   

   chrchr-github

   on May 27, 2026

   ContributorAuthor

   More actions

   Maybe there is an issue, because I'm getting the same warnings which were fixed in #639
   https://github.com/cppcheck-opensource/cppcheck/actions/runs/26506777078/job/78061086273?pr=8586
10. firewave

    reopened this on May 27, 2026
11. firewave commented on May 27, 2026

    

    firewave

    on May 27, 2026

    Collaborator

    More actions

    simplecpp had not yet been updated in your PR. Checking those messages that matches the fixes. So I assume it is an issue with unmatchedSuppression and headers. Will take a look later.
12. firewave

    closed this as completedon May 27, 2026
13. firewave commented on May 27, 2026

    

    firewave

    on May 27, 2026

    Collaborator

    More actions

    It's a bug, alright. I filed https://trac.cppcheck.net/ticket/14792 about it.