Skip to content

Failure when header is included twice with different macros defined #581

Closed
Closed
Failure when header is included twice with different macros defined#581
Assignees
danmar

Description

@danmar
danmar
opened on Nov 1, 2025

file1.c:

# define Y
# include "test.h"

# define BBB
# include "test.h"

test.h:

#if defined AAA
#elif defined BBB
# undef BBB
#endif

#ifdef BBB
# error adf
#endif

Output:

$ ~/simplecpp/simplecpp file.c
test.h:8: #error: #error adf

Activity

  1. danmar
    changed the title [-]Fail to reprocess header, #if conditions should not have the same results[/-] [+]Failure when header is included twice with different macros defined[/+] on Nov 1, 2025
  2. danmar
    self-assigned this
    on Nov 1, 2025

  3. firewave commented on Nov 1, 2025

    @firewave
    firewave
    on Nov 1, 2025
    Collaborator

    Oh wow. That is an issue. I considered this when the include handling was reworked and I thought I raised this is the PR and/or tested it. Apparently I did not ...

  4. danmar commented on Nov 1, 2025

    @danmar
    danmar
    on Nov 1, 2025
    CollaboratorAuthor

    @firewave yeah. please review #582 that fixes this. :-)

  5. danmar
    added a commit that references this issue on Nov 5, 2025

    Fix #581 (Failure when header is included twice with different macros…

    e50c48c
  6. danmar
    closed this as completedin 7a81c1aon Nov 5, 2025
  7. pull
    added a commit that references this issue on Nov 5, 2025

    Fix cppcheck-opensource#581 (Failure when header is included twice wi…

    7a81c1a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions