Repository navigation
docs(release): make changelog check B find changed image build files - #4952
Harshit Rawat (harshitrwt) wants to merge 1 commit into
Conversation
The pathspec 'images/*/Dockerfile' matches nothing because there is no images/ directory at the repository root; image build files live under packages/*/*/images/. Use '*Dockerfile' '*Containerfile' so the check sees both file names at any depth. Signed-off-by: harshitrwt <harshit.rawat1804@gmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
myasnikovdaniil
left a comment
There was a problem hiding this comment.
LGTM, thanks. I ran the new pathspec against the last 13 stable tag ranges, the old one returns nothing on every range and the new one returns the changed Dockerfile and Containerfile files (40 of them on v1.5.4..v1.6.0), no false positives.
The first path in the same loop is dead too (packages/core/talos/values.yaml is empty), I fixed it separately in #4959.
What this PR does
Check B of the changelog pre-publish verification in
docs/release.mdlists changed image build files withgit diff --name-only $PREV..$NEW -- 'images/*/Dockerfile'. That pathspec never matches anything: there is noimages/directory at the repository root, since image build files live underpackages/*/*/images/. The check therefore printed nothing on every release and passed without looking at anything. It also skippedContainerfile, which first-party images such asotelcol-tracingand the dashboardconsoleuse.This PR changes the pathspec to
'*Dockerfile' '*Containerfile', which matches both file names at any depth. I checked it in a scratch repository: the old pathspec returned no files for a changed Dockerfile and Containerfile, and the new one returned both. Every Dockerfile and Containerfile currently in the repository lives underpackages/*/*/images/, so the broader pathspec does not pick up files from vendored charts.Closes #4892
Screenshots
N/A: documentation-only change, no UI impact.
Downstream repositories
Release note
Summary by CodeRabbit
DockerfileandContainerfilefiles anywhere in a diff.