Skip to content

docs(release): make changelog check B find changed image build files - #4952

Open
Harshit Rawat (harshitrwt) wants to merge 1 commit into
cozystack:mainfrom
harshitrwt:docs/release-check-b-image-pathspec
Open

Harshit Rawat (harshitrwt) wants to merge 1 commit into
cozystack:mainfrom
harshitrwt:docs/release-check-b-image-pathspec

Conversation

@harshitrwt

@harshitrwt Harshit Rawat (harshitrwt) commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

What this PR does

Check B of the changelog pre-publish verification in docs/release.md lists changed image build files with git diff --name-only $PREV..$NEW -- 'images/*/Dockerfile'. That pathspec never matches anything: there is no images/ directory at the repository root, since image build files live under packages/*/*/images/. The check therefore printed nothing on every release and passed without looking at anything. It also skipped Containerfile, which first-party images such as otelcol-tracing and the dashboard console use.

This PR changes the pathspec to '*Dockerfile' '*Containerfile', which matches both file names at any depth. I checked it in a scratch repository: the old pathspec returned no files for a changed Dockerfile and Containerfile, and the new one returned both. Every Dockerfile and Containerfile currently in the repository lives under packages/*/*/images/, so the broader pathspec does not pick up files from vendored charts.

Closes #4892

Screenshots

N/A: documentation-only change, no UI impact.

Downstream repositories

Release note

docs(release): make changelog verification check B find changed image build files by matching Dockerfile and Containerfile at any depth

Summary by CodeRabbit

  • Chores
    • Changelog verification now recognizes changes to Dockerfile and Containerfile files anywhere in a diff.

The pathspec 'images/*/Dockerfile' matches nothing because there is no images/ directory at the repository root; image build files live under packages/*/*/images/. Use '*Dockerfile' '*Containerfile' so the check sees both file names at any depth.

Signed-off-by: harshitrwt <harshit.rawat1804@gmail.com>
@github-actions github-actions Bot added size/XS This PR changes 0-9 lines, ignoring generated files area/release Issues or PRs related to release tooling (changelog, backport, release pipeline) kind/documentation Categorizes issue or PR as related to documentation labels Oct 19, 2026
@coderabbitai

coderabbitai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: cozystack/cozystack/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 58428e42-69ba-4609-80cd-0441b718ef80
📥 Commits

Reviewing files that changed from the base of the PR and between aed7fa8 and ec378cc.

📒 Files selected for processing: 1
  • docs/release.md

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

📝 Walkthrough

The changelog verification command now searches the diff for Dockerfile and Containerfile paths at any directory depth.

Changes: Changelog verification

Layer / File(s) Summary
Build-file path matching
docs/release.md
The changed-file check now matches Dockerfile and Containerfile paths anywhere in the diff.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix · Severity of issue fixed: Low

Suggested reviewers: myasnikovdaniil

Merge Risk: ⚪ Minimal · up to ec378

The changelog check now searches for Dockerfile and Containerfile paths at any depth. No actionable merge risk is apparent.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: updating changelog Check B to find changed image build files.
Linked Issues check Passed The change satisfies issue #4892. In docs/release.md, Check B replaces 'images/*/Dockerfile' with '*Dockerfile' '*Containerfile'. This matches both required image build file names at any depth. …
Out of Scope Changes check Passed The whole-PR diff contains one documentation change in docs/release.md. The change directly implements issue #4892 and adds no unrelated source, test, or configuration changes.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Full details: Linked Issues check

Explanation

The change satisfies issue #4892. In docs/release.md, Check B replaces 'images/*/Dockerfile' with '*Dockerfile' '*Containerfile'. This matches both required image build file names at any depth. The issue specifies no additional coding or automated-test requirement.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@myasnikovdaniil myasnikovdaniil left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. I ran the new pathspec against the last 13 stable tag ranges, the old one returns nothing on every range and the new one returns the changed Dockerfile and Containerfile files (40 of them on v1.5.4..v1.6.0), no false positives.

The first path in the same loop is dead too (packages/core/talos/values.yaml is empty), I fixed it separately in #4959.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/release Issues or PRs related to release tooling (changelog, backport, release pipeline) kind/documentation Categorizes issue or PR as related to documentation size/XS This PR changes 0-9 lines, ignoring generated files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs(release): changelog check B looks for images/*/Dockerfile, which does not exist

2 participants