Repository navigation
feat(cozystack): add vm-tenant-move skill - #28
Draft
Andrei Kvapil (kvaps) wants to merge 1 commit into
Draft
Andrei Kvapil (kvaps) wants to merge 1 commit into
Andrei Kvapil (kvaps) wants to merge 1 commit into
Conversation
Moving a VM between tenants has no documented procedure, and copying large disks through backups is slow. Add a skill that moves a VMInstance and its VMDisks without copying data: the PersistentVolume is re-bound to a PVC in the target namespace and CDI adopts it through the storage.populatedFor annotation, which works without disabling CDI webhooks or enabling claim adoption. The kube-ovn IP record is moved the way platform migration 29 does it, so the VM keeps its IP and MAC. Backup restore into another namespace is kept as the fallback. Assisted-by: LLM Signed-off-by: Andrei Kvapil <kvapss@gmail.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
cozystack:vm-tenant-move. It moves a VM (VMInstance and its VMDisks) to another tenant namespace without copying disk data: the PV is re-bound to a new PVC in the target namespace, and the DataVolume is re-created over it.CDI adopts the PVC through
cdi.kubevirt.io/storage.populatedFor, so there is no need to touch the CDI webhooks or feature gates.allowClaimAdoptionon a PVC does nothing in CDI v1.66.1 (CDI reads it from the DataVolume only), that's why migration 29 had to disable the webhooks. IP and MAC are kept by moving theip.kubeovn.iorecord, the same way migration 29 does it.Checked against the code (cozystack main, CDI v1.66.1, KubeVirt v1.9.0), but not run on a live cluster yet, so keeping it as a draft.