Repository navigation
chore: run the shared dash and internal-refs gates from script-utils 0.1.7 - #88
Merged
Merged
Conversation
…0.1.7 The repo-local dash and internal-refs gates are replaced by the shared bins in @cosyte/script-utils 0.1.7 (ST34: one implementation of each gate), and their scripts and self-tests are deleted. - dash: cosyte-no-emdash. scripts/check-no-emdash.exclude leaves out what the local gate left out: the CHANGELOG archive below its boundary heading (`unread`) and the two verbatim hl7-refresh captures, by literal path. - internal refs: cosyte-internal-refs, configured by scripts/internal-refs.json with the same prefixes, designations, surface, doc-comment pass and string-literal pass, plus two extra rules carrying the local phase rule and slice rule as they were (`roadmap §4.5`, `the slice`, `each slice`), so nothing the local gate caught is lost. The PHI scan stays local: its HL7 v2 field detectors (PID-3, PID-5, PID-7, PID-11, PID-13) have no shared counterpart. Every CI job keeps its name; the two gate workflows move to the installing variants of the same shared workflows. Claude-Session: https://claude.ai/code/session_01MXLcW95gf97vs9RBU1YsXf
NSchatz
force-pushed
the
chore/shared-gates-0.1.7
branch
from
November 8, 2026 05:38
31e2cdc to
e941c3c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves transform's dash and internal-refs gates to the shared bins in
@cosyte/script-utils0.1.7 (ST34: one implementation of each gate), and deletes the local scripts and their tests. The PHI scan stays local.What moved
cosyte-no-emdashscripts/check-no-emdash.exclude: the CHANGELOG archive (unreadbelow its boundary) and the two verbatim captures indocumentation/hl7-refresh/, both exactly what the local gate left outcosyte-internal-refsscripts/internal-refs.jsonDeleted:
scripts/check-no-emdash.mjs,scripts/check-no-internal-refs.sh,test/scripts/no-emdash-gate.test.ts.Parity, measured
--stdin: no spelling the local gate caught is missed; the shared gate also catches the eight-digit, braced backslash-x and CSS escapes. Tree cases on throwaway repos: the archive below the boundary stays out, the generated half above it reds, a missing heading fails closed, file names and unreadable tracked files red. The local gate'svendor/binary partition is gone: the shared gate reads those archives too (both scan clean). On this tree both are clean.theandeachas determiners and the local phase rule readsroadmap §4.5,connect-phaseandphase was, which the shared rules let through, so both ride along asextraRuleswith the local self-test samples.What stays local, and why
PHI scan (
scripts/phi-scan.ts). The sharedcosyte-phi-scancarries only the SSN and email floor. On a synthetic ADT^A01 the local scanner reports eight field hits (PID-3 identifier, PID-5 name, PID-7 birth date, PID-11 address, PID-13 phone) and the shared one reports none. It moves when the shared engine ships HL7 v2 field detectors, or as arunPhiScancaller passingdetect.Every CI job keeps its name:
no-emdash.ymlandno-internal-refs.ymlcall the installing variants of the same shared workflows. No published file changes, so no changeset.https://claude.ai/code/session_01MXLcW95gf97vs9RBU1YsXf