Repository navigation
ci: let every dash gate run finish, so a cancelled run cannot block a merge - #87
Merged
Merged
Conversation
… merge no-emdash / tracked-files is a required check, and its caller runs on the edited activity type under a cancelling concurrency group. A push and an edit that land together (Dependabot does both) start two runs, and the group cancels one; when the cancelled run sits in the newer check suite, the required context counts as failing until someone re-runs it. A group without cancel-in-progress still cancels a queued run, so the block is removed and each short run finishes; the newest result stands. Claude-Session: https://claude.ai/code/session_01MXLcW95gf97vs9RBU1YsXf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
no-emdash / tracked-filesis a required check here. Its caller runs on theeditedactivity type under a concurrency group withcancel-in-progress: true. A push and an edit that land together (Dependabot does both) start two runs, and the group cancels one. When the cancelled run sits in the newer check suite, the required context counts as failing and the pull request stays blocked until someone re-runs it.Setting
cancel-in-progress: falsewould not be enough: a group still cancels a queued run when a newer one arrives. So the concurrency block is removed. Each run takes seconds, every one finishes, and the newest result stands. The shared workflow it calls has no concurrency setting of its own. This is the change the PR title caller got in the same way (for example hl7#190).No job is renamed or removed, so the
no-emdash / tracked-filesandno-emdash / messagescontexts are unchanged.Checked locally: every command in CLAUDE.md's gate passes, and actionlint 1.7.12 with shellcheck 0.11.0 is clean on the changed workflow.
https://claude.ai/code/session_01MXLcW95gf97vs9RBU1YsXf