Repository navigation
docs: put the version and fork PR rules on the card - #85
Merged
Merged
Conversation
Two rules the agent notes held that the removal (#83) did not place, one line each on the CLAUDE.md card: - Never move a published version backwards. npm refuses a version once used, consumers pin ranges, and no release step checks the order: the shared release workflow decides a release by the v<version> tag, and its publish-floor check compares tool versions, not package versions. - CI on a fork PR is unproven: none has run here, and a first-time contributor's workflows wait for approval (the repository's policy is first_time_contributors). Tell no contributor a fork PR is fine until one has passed. Claude-Session: https://claude.ai/code/session_01MXLcW95gf97vs9RBU1YsXf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Places two rules the agent notes held that the removal (#83) left without a home, one line each on the CLAUDE.md card (now 54 of 60 lines, 3,228 of 5,120 bytes):
release.ymlthis repo calls decides that a release is pending by whether thev<version>tag exists, and itspublish-floor.mjscompares tool versions, not package versions.gh pr list --state alllists none), and the fork approval policy isfirst_time_contributors, so a first-time contributor's workflows wait for a maintainer's approval. Tell no contributor a fork PR is fine until someone has watched one pass.CLAUDE.mdis not inpackage.jsonfiles, so there is no changeset. The full gate from CLAUDE.md passed locally on Node 26, with one caveat: on a machine at load 20 to 30, three conformance tests intest/conformance/ran 10 to 22 s underpnpm test:coverageagainst the 10 s test timeout, so that step passed (920 of 920, thresholds met) only with--testTimeout=60000.pnpm testpassed them at the standard timeout, and CI runs the standard timeout.https://claude.ai/code/session_01MXLcW95gf97vs9RBU1YsXf