Repository navigation
fix: say what installs @cosyte/fhir instead of claiming it is not on npm - #96
Merged
Merged
Conversation
@cosyte/fhir is on the npm registry. The FHIR and convert unavailable messages now say it arrives as the peer of @cosyte/transform, which an install without peer dependencies leaves out, and to install it alongside @cosyte/cli. Code and exit 69 unchanged. Claude-Session: https://claude.ai/code/session_01MXLcW95gf97vs9RBU1YsXf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
CLI_PARSER_UNAVAILABLEmessage for a missing@cosyte/fhirsaid the package is not on the npm registry. It has been published since August (0.1.4 is latest), so the message sent users away from an install that works. Theconvertmessage made the same claim, and said@cosyte/transformwas not installed even when only its@cosyte/fhirpeer was missing.When the code path still fires (measured against the published 0.1.4 in clean directories):
npm install @cosyte/cliandpnpm add @cosyte/cli: fhir arrives as transform's peer, and FHIR parse exits 0;npm install --legacy-peer-deps: transform is installed, fhir is not, and FHIR parse andconvertexit 69 with the false message;Installing
@cosyte/fhirnext to@cosyte/clifixes it (verified, includingnpx --package @cosyte/cli --package @cosyte/fhir cosyte ...).Changes:
src/core/parsers.ts: the fhir message now says FHIR support is unavailable in this install, that fhir arrives as transform's peer, which an install without peer dependencies leaves out, and to install@cosyte/fhiralongside@cosyte/cli.src/commands/convert.ts: the transform message names both packages, does not claim which is missing, and says to install both alongside@cosyte/cli.test/absent-sibling.test.ts: asserts the new wording, that neither message mentions the registry, and that both end with the install instruction.docs-content/troubleshooting.md: the npx form and--legacy-peer-depsas one install that leaves fhir out.RELEASING.md: dated note that fhir is published and the August record is history.Code (
CLI_PARSER_UNAVAILABLE) and exit code (69) are unchanged; both messages stay value-free (package names only). Patch changeset included.https://claude.ai/code/session_01MXLcW95gf97vs9RBU1YsXf