Repository navigation
chore(ci): say which rulesets require which CI contexts - #103
Merged
Merged
Conversation
The comments in ci.yml said the documents and examples jobs are not required contexts. The repository's ci-required-checks ruleset (19907924) requires both. The banner and the Node matrix note also credited the ci / * contexts to ci-required-checks and called Node 26 not required: the organization's library-required-checks ruleset requires all five ci / * contexts, Node 26 included. Comments only. Claude-Session: https://claude.ai/code/session_016orFiNW8PuZkqnC8pqqTP2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comment-only correction in
.github/workflows/ci.yml. No behaviour changes and no changeset.examplesanddocuments: the comments said neither is a required context. The repository'sci-required-checksruleset (19907924) requires both, so the comments now say so.ci-required-checksrequires four of the fiveci / *contexts and thatci / verify (26, ubuntu-latest)is not required. The organization'slibrary-required-checksruleset (26785819) requires all five, Node 26 included, andci-required-checksholdsdocumentsandexamples. Both rulesets havebypass_actors: [].Checked:
pnpm format:check,pnpm check:no-emdash,pnpm check:no-internal-refs, andtest/node-support.test.ts(it reads this file) pass.https://claude.ai/code/session_016orFiNW8PuZkqnC8pqqTP2